Rename scripts, fix logging, update GPU tests #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nailimixaM
requested review from
LianaMikael,
jameshensman,
msdmkats,
myshkov and
pashminacameron
myshkov
approved these changes
Feb 27, 2024
pashminacameron
approved these changes
Feb 27, 2024
Collaborator
Author
|
@myshkov I've added an update to logging in |
nailimixaM
changed the title
LianaMikael
reviewed
Feb 27, 2024
| pip install -e .[finetune] | ||
| ``` | ||
|
|
||
| The following replicates the experiments in the paper (LoRA hyperparams valid for all Llama-2 and Phi-2 models): |
Contributor
There was a problem hiding this comment.
Have you tried running this with the fixes that I added in my PR #101 yet? I expect better results than in the paper
Contributor
There was a problem hiding this comment.
We should do this, but it can come as a separate change, with another update to the readme if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.